Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

succeeded and failed states #47

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

scott-cotton
Copy link
Member

@scott-cotton scott-cotton commented Jun 11, 2024

This PR is stacked on #46 and replaces "completed" state/phase with succeeded/failed state/phase.

It depends on https://github.com/signadot/signadot/pull/4519

Base automatically changed from job-logs-error-handling-fixes to main June 11, 2024 12:48
Copy link
Contributor

@daniel-de-vera daniel-de-vera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-cotton scott-cotton merged commit 32c035d into main Jun 11, 2024
2 checks passed
@scott-cotton scott-cotton deleted the job-succeeded-failed-phase branch June 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants