Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make exit code in failed state a pointer #51

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

scott-cotton
Copy link
Member

@scott-cotton scott-cotton commented Jun 13, 2024

by manually adding the x-nullable property to the swagger.json

For context, see go-swagger/go-swagger#2166

Part of https://github.com/signadot/signadot/issues/4556

by manually adding the `x-nullable` property to the swagger.json
Copy link
Contributor

@daniel-de-vera daniel-de-vera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that there is no need to do this change manually.
I would also make the following change in the API spec:

type FailedState struct {
	ExitCode     *int   `json:"exitCode" extensions:"x-nullable"`
	Message      string `json:"message,omitempty"`
	RetryAttempt bool   `json:"retryAttempt"`
}

@davixcky
Copy link
Contributor

LGTM.

Note that there is no need to do this change manually. I would also make the following change in the API spec:

type FailedState struct {
	ExitCode     *int   `json:"exitCode" extensions:"x-nullable"`
	Message      string `json:"message,omitempty"`
	RetryAttempt bool   `json:"retryAttempt"`
}

Better in api spec, otherwise other thing to keep track

@scott-cotton
Copy link
Member Author

added the tag (nice find! thanks) here https://github.com/signadot/signadot/pull/4558

@scott-cotton scott-cotton merged commit 99844d1 into main Jun 13, 2024
2 checks passed
@scott-cotton scott-cotton deleted the exit-code-as-point branch June 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants