Store and forward #2423
Closed
Store and forward #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Make credentials dynamic, so that registration changes are reflected in existing service threads. 2) Dedicate a single thread to websocket message retrieval, rather than using an executor. Wrap the whole thing in catch blocks, so that okhttp's internal problems don't take out our thread.
| private static class GcmRegistrationId { | ||
| private String gcmRegistrationId; | ||
| private boolean webSocketChannel; |
There was a problem hiding this comment.
this doesn't look like it's used anywhere
There was a problem hiding this comment.
This is a JSON POJO. It's transmitted to the server.
There was a problem hiding this comment.
why not do private boolean webSocketChannel = true;?
There was a problem hiding this comment.
not really how json pojos are written, and i want to be explicit to the caller
|
updated the copyright header and indentation |
|
|
||
| try { | ||
| if (isTextSecureEnvelope(request)) { | ||
| TextSecureEnvelope envelope = new TextSecureEnvelope(request.getBody().toByteArray(), |
There was a problem hiding this comment.
since body is optional in the protobuf, could someone just send an envelope without one and cause NPE here?
There was a problem hiding this comment.
"someone" here is the server, which i'm willing to trust with an npe
|
haven't run it yet, but code lgtm :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.