Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the max sizes for message limits delivered by push #4022

Closed
wants to merge 1 commit into from

Conversation

richo
Copy link
Contributor

@richo richo commented Sep 5, 2015

I picked totally arbitrary numbers that seemed reasonable sounding at
the time.

closes #700

in #700 (comment) @mcginty wrote:

It's just a matter of limiting auto-downloads of large files depending on the network you're on before we increase the size.

However naively, it seems that a malicious implementor of TextSecure's protocol can already bypass this limit, if the only restrictions are client side at present. Thus I propose raising the limit.

I'm totally onboard with picking other numbers, I literally just eyeballed a minute long video.

I picked totally arbitrary numbers that seemed reasonable sounding at
the time.

closes signalapp#700
@richo
Copy link
Contributor Author

richo commented Sep 5, 2015

More specifically, sending gigantor videos from Signal to TextSecure works today, so unless I'm missing something, this guard isn't protecting anything significant.

@rmueller83
Copy link

I think this is already addressed by #4019

@richo
Copy link
Contributor Author

richo commented Sep 5, 2015

Oh whoops. I found my way here from #700 which doesn't mention it.

@richo richo closed this Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Limited video size?
2 participants