Improve error handling when group members unregister

[haffenloher]

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution on these devices:
  • Emulator, Android 5.1
• My contribution is fully baked and ready to be merged as is
• I have made the choice whether I want the Bithub reward or not by omitting or adding the word FREEBIE in my commit message

---

Description

• Store UnregisteredUsers in the DB (just like NetworkFailures / IdentityKeyMismatches) and display an error text for them in the message details
• Add a "More info" button to the MessageRecipientListItem of the unregistered recipient which opens an AlertDialog, informing the user of the problem
• After acknowledging / closing the dialog, group messages to this recipient no longer fail (in the UI)

Screenshots

Edit: These are all obsolete

Fixes #2408
Fixes #4550

[haffenloher]

Added information on whether a group member has unregistered to the GroupMembersDialog - thanks to @agrajaghh for the hint:

[agrajaghh]

👍
just an idea: maybe add a newline inbetween? is that possible there?

[haffenloher]

Done, looks like this:

[2-4601]

How about formatting the contact name with strikethrough? (If it's simple enough to do)
Android Emoji Fan
(no longer registered)

[agrajaghh]

I think its a bit better, no? This dialog is so ugly anyway... 😱 I started working on improving this, but didn't had the time to finish it yet. Hopefully I'm less busy soon 😉

@2-4601 good idea!

[haffenloher]

@agrajaghh cool, a rework of this thing would be nice for sure!
@2-4601 I think that would require some more changes to the dialog, so I'll leave it to @agrajaghh :)

[agrajaghh]

should be possible with a spannable and http://developer.android.com/reference/android/graphics/Paint.html#STRIKE_THRU_TEXT_FLAG I think

edit: or http://developer.android.com/reference/android/text/style/StrikethroughSpan.html

[haffenloher]

you're right, I thought it would be more complicated:

Still not that beautiful though 😊

[moxie0]

i'd like it to just not display any error state when someone is unregistered

[2-4601]

@haffenloher What happens in this scenario:

• you have acknowledged the unregistered member with "Got it"
• you go to a poor network coverage area
• you try to send a message to the group
• sending fails for the unregistered contact with the error "failed to send"

Is it going to offer the option to send again to that contact?

[haffenloher]

@moxie0 done, cuts the diff in half =)

@2-4601 yes, you would have seen the resend button in that scenario. Anyway, as per moxie's request there's now no error state, no AlertDialog and no "Got it" button anymore ;)

[moxie0]

oh no I mean I don't want any state tracking at all. everything's the same, except you don't get an error when someone in the group has unregistered

[haffenloher]

Oops... okay, I removed all the other stuff and force-pushed. This is just a tiny 10-line change now.

[moxie0]

if (e.getNetworkExceptions().isEmpty() && e.getUntrustedIdentityExceptions().isEmpty() { ...

[haffenloher]

@moxie0 thanks! that looks better.