Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve TODO to use BTreeMap::pop_first #13

Closed
wants to merge 1 commit into from
Closed

Resolve TODO to use BTreeMap::pop_first #13

wants to merge 1 commit into from

Conversation

akonradi
Copy link
Contributor

BTreeMap::pop_first was stabilized in Rust 1.66.0. Use it in place of BTreeMap::remove and resolve the TODO.

@akonradi
Resolve TODO to use BTreeMap::pop_first
9cc2c2f 
BTreeMap::pop_first was stabilized in Rust 1.66.0. Use it in place of
BTreeMap::remove and resolve the TODO.
@rashad-signal
Copy link
Contributor

Thanks for the contribution! Could you sign our CLA and we can get this merged?

@akonradi
Copy link
Contributor Author

Yep, done!

rashad-signal
rashad-signal approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@rashad-signal rashad-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! We've taken this change in and you'll see your commit in the next release.

@rashad-signal
Copy link
Contributor

The commit is here: 519ccb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashad-signal rashad-signal rashad-signal approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akonradi @rashad-signal