Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to view image in default browser. #3020

Closed
1 task done
ScottYates opened this issue Jan 4, 2019 · 7 comments
Closed
1 task done

Add button to view image in default browser. #3020

ScottYates opened this issue Jan 4, 2019 · 7 comments

Comments

@ScottYates
Copy link
Contributor

ScottYates commented Jan 4, 2019

  • I have searched open and closed issues for duplicates

Feature Request Description

Images on desktop app are constrained to the size of the signal window. This makes them hard to view. It seems like a good idea to present a button that would allow you to open the image in the default browser so you could use it to zoom/pan around the image.

this should also solve this issue:
#1042

@ScottYates ScottYates changed the title Add button to view image sent in signal in default browser. Add button to view image in default browser. Jan 4, 2019
@etanot
Copy link

etanot commented Feb 23, 2019

@scottnonnenberg-signal Can we provide those basic functionality inside the desktop app rather than depending on external app?

@ScottYates
Copy link
Contributor Author

I am not sure. One of the main problems is the image being limited to the size of the desktop app window. Since it is a chat app, I (and i suspect others) relegate it to a small window.

Can that particular problem can be solved by opening a new possibly full screen window outside of the Signal desktop app in which to view it? I am ignorant of the limitations involved.

@metronidazole
Copy link

metronidazole commented Feb 24, 2019

@finn0

Why? Almost every OS (with a GUI) supports the concept of a default image viewer.

This should be high priority as the lack of a feature makes it a PITA to view desktop images. I first have to save an image, then browse to actually see what is in an image.

What should be a one click process, takes a dozen clicks and takes 5x as long to do.

@ScottYates
Copy link
Contributor Author

What @metronidazole says is true. The concept of a "default image viewer" is there in every modern desktop OS I know of. And his pain point is one I share (and I suspect we are not in the minority).

@etanot
Copy link

etanot commented Mar 24, 2019

@metronidazole @beernutz

Why? Almost every OS (with a GUI) supports the concept of a default image viewer.

But I think It'd be nice to have zooming feature inside the app (if possible) just like Signal app in mobile devices because most of time we just want to see/read the content inside the image file. And for more advance features we can open it in our favorite image viewer application. Signal stores images in encrypted form then why would we save it inside the OS just to view zoomed image?

@ministroni
Copy link

If the desktop app already saves the image out somewhere on the file system, it makes sense it could just open that file. I kind of doubt that though. It should be (and probably is) encrypted within the app until you save it. I'd much rather just have clicking open a "fullscreen" view of the images that's still contained within Signal itself. I'd much prefer that to having it publicly viewable like hangouts just to send it to my browser, or automatically saving it unencrypted just so my default image viewer could open it.

@stale
Copy link

stale bot commented Sep 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants