Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlink device from user's account on 'Clear All Data' #3728

Closed
1 task done
NFM-8 opened this issue Nov 9, 2019 · 2 comments
Closed
1 task done

Unlink device from user's account on 'Clear All Data' #3728

NFM-8 opened this issue Nov 9, 2019 · 2 comments

Comments

@NFM-8
Copy link

NFM-8 commented Nov 9, 2019

  • I have searched open and closed issues for duplicates

Bug Description

Clearing all data from a desktop client session does not unlink the underlying session from the master device, leaving a stale session that cannot be used anymore (the key material is cleared also, right?).

Steps to Reproduce

  1. Link desktop
  2. Push the Clear data button in menu
  3. Finalize clearing by pushing Delete all data
  4. Open linked devices on the master device
  5. Observe that the session created in step 1 still exists

Actual Result:

Stale session is left hanging around.

Expected Result:

Session is unlinked.

NFM-8 pushed a commit to NFM-8/Signal-Desktop that referenced this issue Nov 9, 2019
@NFM-8
Copy link
Author

NFM-8 commented Nov 9, 2019

Tried to fix this issue in NFM-8@8b1e197 but server seems to give 401 when trying to unlink. Perhaps only the master device is currently allowed to unlink devices?

@scottnonnenberg-signal scottnonnenberg-signal changed the title Clear data does not unlink "the device" Unlink device from user's account on 'Clear All Data' Nov 11, 2019
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants