On hold: Mute conversation #1310
Conversation
scottnonnenberg
force-pushed
the
combined
branch
from
a14e3a1
to
6971cb3
Compare
(difficulty right now is that we can't re-render whole conversation) FREEBIE
scottnonnenberg
force-pushed
the
mute-conversation
branch
from
35fd4b5
to
cca01e8
Compare
|
Agreed. Mine was a simple implementation but definitely a more uniform and nicer UI is more than a welcome 😸 |
|
If I rebase this PR and clean it up, would y'all consider merging it? Or is this feature just not being considered anymore? (I've noticed there's already been two PRs and neither were merged...) |
|
@duckinator The remaining work is UI-intensive (and incomplete), so we'd want to get very clear on the intended experience before you write any code. |
|
@scottnonnenberg-signal Signal-Android does apparently not support receiving sync blocked messages yet |
|
@scottnonnenberg does that mean the "Mute Conversation"/"Unmute Conversation" toggle this PR has currently is considered insufficient? |
|
@Trolldemorted Blocking and muting are different things. We're talking here about a notification-only setting specific to the local device. @duckinator Exactly. The work in the PR is not complete. The 'WIP:' prefix on the most recent comments stands for 'Work in progress' |
|
what is the status of this? Its still very annoying to use signal-desktop when you are member in a lot of groups... |
This work is on hold for a while, so this PR is mostly to get this code off of my machine and get its in-progress state tracked. Basically, this 'mute conversation' feature just needs some work on the UI.
As implemented in #907, the feature worked but was a little clunky. The entry in the top-right menu was 'Mute/unmute conversation' and the only indication that a conversation was muted was in the left-side menu.
The two WIP commits included in this PR are starting to push towards a better UI. Something a little more like what we do for disappearing messages.