Ensure final message before 'empty' is ready for notification #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, there's a race condition for the notification we show when we get the 'empty' event after a large backlog download. Four messages may have come in, but the last might not be notified. So the count shown would be three. And then, when the final message's notify() call finishes, another notification would be shown. FREEBIE
scottnonnenberg
added a commit
that referenced
this pull request
Sep 29, 2017
Make long-lived socket connections more reliable (#1511) Show offline state faster on loss of network access (#1512) Notifications: - Only show notifications when a large backlog download is complete (#1507) - Ensure final message before 'empty' is ready for notification (#1522) Ensure we always replace $name$ variable in strings (#1520) Update strings for fa, no, pt_BR, pt_PT, ro, zh_CN, zh_TW (#1517) Update electron to v1.6.14 to get security fix (#1519) Eliminate warning on Windows installation with code-signing (#1513) Dev: - Move logging to disk via bunyan - should make message processing faster! (#1506) - Only retry messages on startup, not every reconnect (#1510) - Log call messages instead of throwing error (#1504) - Redact group ids in logging (4c48d12) - Remove manifest.json from project (3a3f249) FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, there's a race condition for the notification we show when we get the 'empty' event after a large backlog download. If four messages have come in, the last might not be included in the first notification. So the count shown would be three. And then, when the final message's
notify()call does finish, another notification would be shown.