feat(input): added ascii to emoji conversion

[dasois]

First time contributor checklist:

• I have read the README and Contributor Guidelines
• I have signed the Contributor Licence Agreement

Contributor checklist:

• My contribution is not related to translations.
• My commits are in nice logical chunks with good commit messages
• My changes are rebased on the latest main branch
• A yarn ready run passes successfully (more about tests here)
• My changes are ready to be shipped to users

Description

Re #1389
Closes #4942

Testing was done manually. If sensible, I can add automated tests for this feature.

[correctmeifimwrong33]

How does this compare to the previous pull request?

• Will it surprise-replace data upon pressing enter and then automatically send the modified message?
• Will one be able to type sequences like "A man (88) became the first..." or "RE:PUBLICA" without finding a 😎 and 😛 in your text?
• Will one be able to paste code or data that may contain any which character sequence without it being replaced?

[Temppus]

Tagging @indutny-signal for review. It has been 2 months, please do not let these changes go stale again due to inactivity.

[Temppus]

Another two weeks of silence. @indutny-signal ?

[Temppus]

@josh-signal @indutny-signal
Another month, another radio silence.
I get that they may be more important features that you are working on, but at least comment on this, it is not gigantic PR.

[Temppus]

🤡

[DaGaMs]

Crazy. This makes me very worried about the level of developer bandwidth at signal. It's impossible to not get the impression that there are no resources for even the most limited maintenance, while still trying to introduce new features.

[correctmeifimwrong33]

I really hope they keep ignoring it because this type of buggy behavior will be hecking annoying. @DaGaM: a risky change is not the same as "even the most limited maintenance"...

[imario42]

... and I hope they will implement a functionality like this. Like in WA where the replacement happens during typing and one can undo the emoji-replacement by simply hitting "backspace". Other solutions can be thought of for sure too.

[indutny-signal]

Hello everyone! Terribly sorry for the long wait. This was merged with some minor improvements and will be released in a few weeks. Thank you so much for your patience!

[Temppus]

Hi, according to v6.43.1...main
It should be merged and available in v6.43.1 version right ?
I am using this version

but it does not work for me, is there problem on my side ?
Can someone verify whether this works ?

[ayumi-signal]

@Temppus Please check your Preferences (File Menu -> Preferences -> Chats). Is it turned on there?

[maximbaz]

Hi, according to v6.43.1...main
It should be merged and available in v6.43.1 version right ?

Not quite, this shows the changes since after v6.43.1 release and up until current main. So the change hasn't made it to v6.43.1.

To see what got merged in v6.43.1, you can compare for example it against the previous release, e.g. v6.43.0...v6.43.1

[ayumi-signal]

ah @maximbaz is right! thanks for noting that :)

[Temppus]

Thanks, I will wait till next release then 😄

[Temppus]

I noticed that with the latest update, a new feature was merged, and I can now see this option. However, I am very disappointed with how this feature was integrated. I did not expect that under the label merged with some minor improvements in this pull request, half of the emojis from the mapping were "silently" removed.

Could you please explain the motivation behind the decision to remove support for them? No one raised any comments or objections about the proposed mapping support. Almost all messaging apps support :D and :) as emoji substitutions.

This leaves me wondering why these were removed.

Thank you for your answer. @indutny-signal @ayumi-signal