-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Description
- [ x ] I have searched open and closed issues for duplicates
- [ x ] I am submitting a bug report for existing functionality that does not work as intended
- [ x ] This isn't a feature request or a discussion topic
Bug description
This is discussed in Issue 4359 & Issue 5404 and it was marked as solved, but the situation is still reported by some users.
I have found some conditions under which the bug still appears, and it has to do with the visibility of the keyboard, the direction in which you turn the phone, as well as the number of 90 deg rotations when starting recording from landscape orientation.
This issue is NOT present if you press the mic button and start recording an audio message from portrait orientation while the keyboard is visible: you can rotate the device in any direction, the message keeps recording. Nor does the bug appear when the keyboard is hidden, but you rotate the device CCW.
However, with the keyboard hidden, if you press the mic button to record a message at the bottom of the screen, then rotate your phone clockwise to landscape, the audio recording cancels and what you've recorded gets lost. Very frustrating corner case.
Steps to reproduce
- make sure your device's rotation lock is off, so the screen changes orientation,
- go to a Signal conversation,
- make sure the keyboard is not visible, or hide it by swiping down in the conversation,
- start recording an audio message by pressing the mic button at the bottom right of the screen,
- tilt your phone TO THE RIGHT (clockwise) so that the screen changes orientation.
Actual result: The voice recording stops and the recorded voice message disappears. Two haptic feedback buzzez.
Expected result: The voice recording continues, as it does when the keyboard is visible or when you rotate your device to the left. One haptic feedback buzz.
Additional cases in which this issue occurs:
Actually, after additional fiddling around, it turns out recording an audio message also cancels in the following situations:
- When keyboard is visible and you start recording in left landscape, rotate right to portrait, then rotate right again to right landscape, after the second rotation, the recording stops;
-- the bug is present in the opposite sense as well, when you start recording in right landscape, and rotate phone to upright, then to left landscape,
-- weirdly, the bug does not show up when rotating the phone directly 180 deg from right landscape to left landscape, or vice-versa, - When keyboard is hidden, in the situations described above with two consecutive 90 deg rotations.
It looks like the way this is implemented is that the voice recording locks before changing orientation.
You can start recording in portrait by pressing the mic button, rotate to landscape and you can feel the haptic one-buzz that is the same as locking the recording. Then you can remove your finger from the screen and the recording keeps going no matter which way you turn the phone. This issue appears, though, if you keep your finger on the screen and turn the phone around a bit more. Recording stops with two buzzez, same as when you swipe to "cancel".
Please make sure that you test ALL the above cases after the fix, so we don't leave the bug hidden in some weird corner case(s) where we may end up losing our recording(s) again.
Device info
Device: iPhone 12 mini
iOS version: 18.0.1
Signal version: 7.53