deps: fetch build artefacts using a proxy where necessary #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsgruk
force-pushed
the
better-sqlcipher
branch
from
4c84833
to
e848dbd
Compare
jnsgruk
force-pushed
the
better-sqlcipher
branch
from
e848dbd
to
f3e4fd5
Compare
jnsgruk
force-pushed
the
better-sqlcipher
branch
from
0f10c57
to
93b5922
Compare
|
@indutny-signal - sorry for the direct ping, you seem to be the most active contributor on this project. Any chance you could take a look here? :) |
|
@indutny-signal / @trevor-signal are you able to take a look at this with a view to getting it in a future Signal Desktop release? Thank you! 🙏 |
|
@indutny-signal @trevor-signal @jamiebuilds-signal any chance of a look at this? Many thanks! 🙂 |
|
@indutny-signal @trevor-signal @jamiebuilds-signal any update on this at all? Thank you! |
|
@ayumi-signal is there any way to get some attention on this? :) thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been struggling to build Signal from source where the build machine is behind a proxy.
This change will have no effect during build unless the
HTTPS_PROXYvariable is set, in which case it establishes an agent that will ensure thehttps.getcalls use the proxy correctly.I'm open to suggestions on a different approach if the addition of another dependency is too undesirable.