This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
pkg-config file updates: 'Libs: -lm' + no '/signal' in 'Cflags: -I' #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when linking using the
pkg-config
file,-lm
is missing. As far as I can see it is used only once:libsignal-protocol-c/src/hkdf.c
Line 109 in 71954c5
-lm
to thepkg-config
file.It also removes the trailing path component
/signal
for the-I
option inlibsignal-protocol-c.pc.in
, as this leads to "namespace pollution" in the sense that everypkg-config
user of this library cannot use the file names of any header filelibsignal-protocol-c
provides (which are quite many). Leaving the path prefixed bysignal/
on the client side is cleaner (and also what other libraries'pkg-config
file exports, e.g., OpenSSL has its headers ininclude/openssl/
but does not include the suffix in its-I
option).Thanks for your consideration.