Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set imports_granularity = "Module" #476

Conversation

cosmicexplorer
Copy link
Contributor

Upon the suggestion of this comment (#287 (comment)), we modify our rustfmt config to splat out imports by each module.

Copy link
Contributor

@jrose-signal jrose-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concerns as #470 about how to merge, but thank you!

use crate::proto::cds2;
use crate::snow_resolver;
use crate::{client_connection, dcap, snow_resolver};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I didn't expect this change, but I am still in favor of rustfmt managing imports, so okay.

@cosmicexplorer
Copy link
Contributor Author

As noted in #470, I have created a branch docs-effort at https://github.com/cosmicexplorer/libsignal-client/tree/docs-effort which incorporates this change! This change is the first to be merged into that branch, at the top of the checklist I'm maintaining in #467.

cosmicexplorer added a commit to cosmicexplorer/libsignal that referenced this pull request Jul 19, 2022
@jrose-signal
Copy link
Contributor

Cherry-picked as c8b81c9, will be in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants