Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set libyuv_use_sme to false on Linux arm64 to fix undefined symbol error on ARMv8 devices #63

Closed
wants to merge 1 commit into from
Closed

Set libyuv_use_sme to false on Linux arm64 to fix undefined symbol error on ARMv8 devices #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bin/build-electron
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,15 @@ then
WEBRTC_ARGS="${WEBRTC_ARGS} is_debug=false symbol_level=1"
fi

# SME requires the ARMv9-A architecture, while most ARM64 devices are ARMv8. This was causing
# "undefined symbol: __arm_tpidr2_save" errors on such devices, including GitHub's ubuntu-22.04-arm runner.
# https://issuetracker.google.com/issues/359006069
# https://chromium.googlesource.com/libyuv/libyuv/+/61354d2671d9b5c73cc964415fe25bc76cea051a/BUILD.gn#273
if [ "$(uname)" = "Linux" ] && [ "${TARGET_ARCH}" = "arm64" ]
then
WEBRTC_ARGS="${WEBRTC_ARGS} libyuv_use_sme=false"
fi

(
cd src/webrtc/src
gn gen -C "${OUTPUT_DIR}/${BUILD_TYPE}" "--args=${WEBRTC_ARGS}"
Expand Down