Skip to content

Commit

Permalink
Revert "Remove iOS Debug (simulator) from LKGR bots."
Browse files Browse the repository at this point in the history
This reverts commit 4bded96.

Reason for revert: Fixed with https://webrtc-review.googlesource.com/c/src/+/357640

Original change's description:
> Remove iOS Debug (simulator) from LKGR bots.
>
> Temporarily skip while the bot gets fixed.
>
> Bug: chromium:353975341
> Change-Id: Ib42c18e929547c7abc58f2878c79f00f87001cae
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357540
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Artem Titov <titovartem@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#42656}

Bug: chromium:353975341
Change-Id: I184c9e597a28fff3ae052a07d8e6f17cc2251188
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357661
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42664}
  • Loading branch information
jleconte2 authored and WebRTC LUCI CQ committed Jul 22, 2024
1 parent 7b61b84 commit 1ac162e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
4 changes: 1 addition & 3 deletions infra/config/config.star
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ def os_from_name(name):
# Add names of builders to remove from LKGR finder to this list. This is
# useful when a failure can be safely ignored while fixing it without
# blocking the LKGR finder on it.
skipped_lkgr_bots = [
"iOS Debug (simulator)",
]
skipped_lkgr_bots = []

# Use LUCI Scheduler BBv2 names and add Scheduler realms configs.
lucicfg.enable_experiment("crbug.com/1182002")
Expand Down
1 change: 1 addition & 0 deletions infra/config/cr-buildbucket.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -1903,6 +1903,7 @@ buckets {
' "Win64 Debug (Clang)",'
' "Win64 Release (Clang)",'
' "iOS API Framework Builder",'
' "iOS Debug (simulator)",'
' "iOS64 Debug",'
' "iOS64 Release"'
' ]'
Expand Down
5 changes: 5 additions & 0 deletions infra/config/luci-notify.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,11 @@ notifiers {
name: "iOS Debug (simulator)"
repository: "https://webrtc.googlesource.com/src"
}
tree_closers {
tree_status_host: "webrtc-status.appspot.com"
failed_step_regexp: "bot_update|compile|gclient runhooks|runhooks|update|extract build|cleanup_temp|taskkill|compile|gn"
failed_step_regexp_exclude: ".*\\(experimental\\).*"
}
}
notifiers {
notifications {
Expand Down
2 changes: 1 addition & 1 deletion infra/config/project.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
name: "webrtc"
access: "group:all"
lucicfg {
version: "1.43.9"
version: "1.43.8"
package_dir: "."
config_dir: "."
entry_point: "config.star"
Expand Down

0 comments on commit 1ac162e

Please sign in to comment.