Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DNS resolution of remote ICE candidates. #6

Merged
merged 1 commit into from
May 12, 2020
Merged

Disable DNS resolution of remote ICE candidates. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion p2p/base/p2p_transport_channel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,14 @@ void P2PTransportChannel::AddRemoteCandidate(const Candidate& candidate) {
}

if (new_remote_candidate.address().IsUnresolvedIP()) {
ResolveHostnameCandidate(new_remote_candidate);
// Do not resolve remote candidates because doing so causes a connection to a DNS
// server which can leak the local agent's public IP address to the DNS server.
// ResolveHostnameCandidate(new_remote_candidate);

// Do not process the ICE candidate further because TCPPort may still attempt
// a resolution of DNS hostnames later on for TCP candidates, despite
// the fact that we didn't resolve the hostname above, which could also
// leak the local agent's IP address to the DNS server.
return;
}

Expand Down