Add data collection configuration for Kubernetes #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add language around Splunk Observability versus Platform
dmitryax
reviewed
Nov 3, 2021
dmitryax
reviewed
Nov 3, 2021
dmitryax
reviewed
Nov 3, 2021
dmitryax
reviewed
Nov 3, 2021
dmitryax
reviewed
Nov 3, 2021
dmitryax
reviewed
Nov 5, 2021
dmitryax
reviewed
Nov 6, 2021
MrAlias
reviewed
Nov 9, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
flands
commented
Nov 9, 2021
dmitryax
reviewed
Nov 10, 2021
dmitryax
approved these changes
Nov 10, 2021
owais
reviewed
Nov 10, 2021
There was a problem hiding this comment.
Looks good. Left a nit-picky suggestion.
Q: Do we want to specify k8s API namespace(s) here? These are used whenever we install any custom resource definition in a k8s cluster. For example, the operator today uses o11y.splunk.com as the API namespace for Otel deployments. Do we want to prescribe this or out of scope for this PR? ref: https://github.com/signalfx/splunk-otel-collector-operator/blob/main/docs/splunkotelagent_cr_spec.md#splunkotelagent-custom-resource-specification
MrAlias
approved these changes
Nov 10, 2021
owais
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add language around Splunk Observability versus Platform