Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type definition for Signalflow client #119

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

dnaik-sfx
Copy link
Contributor

Add filter param to the Signalflow client ExecuteOptions definition (allows filters to be passed in separately from the program text when executing Signalflow).

@dnaik-sfx dnaik-sfx requested review from a team as code owners February 29, 2024 23:49
@dnaik-sfx
Copy link
Contributor Author

@seemk Could you take a look at this PR when you get a chance?

@seemk
Copy link
Contributor

seemk commented Mar 7, 2024

@dnaik-sfx I can't merge as GH requires signed commits, can you sign the commits and push again?

Add `filter` param to the Signalflow client `ExecuteOptions`
definition (allows filters to be passed in separately from
the program text when executing Signalflow).
@dnaik-sfx
Copy link
Contributor Author

@dnaik-sfx I can't merge as GH requires signed commits, can you sign the commits and push again?

Done

@seemk seemk merged commit 393276b into signalfx:main Mar 7, 2024
6 checks passed
@seemk
Copy link
Contributor

seemk commented Mar 7, 2024

Thanks, I'll do the release on Friday

@dnaik-sfx
Copy link
Contributor Author

Awesome, thanks!

@seemk seemk mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants