Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with sending livetail reg prematurely #60

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Fixes issue with sending livetail reg prematurely #60

merged 2 commits into from
Oct 9, 2020

Conversation

amoshg-sfx
Copy link
Contributor

No description provided.

mpetazzoni
mpetazzoni approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@mpetazzoni mpetazzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work okay but I'd love to see a more consistent mechanism for pending WS requests.

@amoshg-sfx amoshg-sfx merged commit 7d6696f into master Oct 9, 2020
@mpetazzoni mpetazzoni deleted the bugfix/BEAV-595-livetail-send-error branch October 11, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetazzoni mpetazzoni mpetazzoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amoshg-sfx @mpetazzoni @amoshgabadi