Remove winston logger #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauno56
approved these changes
Apr 10, 2021
This commit removes winston logger as a dependency and replaces it with a very simple console.log based implementation. The implementation satisfies all current uses of the winston logger in this library. This shaves off about 700 kilobyes un-gzipped from bundle size and removes a few indirect dependencies which is very good for enviorments like AWS Lambda. This also makes it possible to build the library with esbuild which had issues with one of it's dependencies (logform).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes winston logger as a dependency and replaces it with
a very simple console.log based implementation. The implementation
satisfies all current uses of the winston logger in this library.
This shaves off about 700 kilobyes un-gzipped from bundle size and
removes a few indirect dependencies which is very good for enviorments
like AWS Lambda.
This also makes it possible to build the library with esbuild which had
issues with one of it's dependencies (logform).