Stop existing livetail session before creating new one #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
approved these changes
Mar 14, 2022
seemk
approved these changes
Mar 14, 2022
amoshgabadi
force-pushed
the
BEAV-1254/many-livetail-sessions
branch
from
41bc50b to
9c71fd3
Compare
seemk
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this is trying to fix is that the logs backend is seeing unusually high number of livetail registration requests from users causing many active sessions at a time.
From what I'm able to repro, if the socket disconnects and the tab is active it will try to call reconnect which will call the retry method on livetail registration without stopping the existing livetail session. This change makes sure stop is called before retry.