Skip to content

Commit

Permalink
Remove a problematic networkExplorer deprecation note
Browse files Browse the repository at this point in the history
Remove networkExplorer deprecation note that can cause the chart installation to fail
  • Loading branch information
dmitryax committed Feb 14, 2024
1 parent 4112047 commit ff16015
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
8 changes: 8 additions & 0 deletions .chloggen/remove-broken-notes-section.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: chart
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove networkExplorer deprecation note that can cause the chart installation to fail
# One or more tracking issues related to the change
issues: [1162]
3 changes: 0 additions & 3 deletions helm-charts/splunk-otel-collector/templates/NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ Splunk OpenTelemetry Collector is installed and configured to send data to Splun
- Some libraries may be enabled by default. For current status, see: https://github.com/open-telemetry/opentelemetry-operator#controlling-instrumentation-capabilities
- Splunk provides best-effort support for native OpenTelemetry libraries, and full support for Splunk library distributions. For used libraries, refer to the values.yaml under "operator.instrumentation.spec".
{{- end }}
{{- if and (not (eq (toString .Values.networkExplorer) "<nil>")) .Values.networkExplorer.enabled }}
{{ fail "Network explorer is not part of this helm chart anymore. Please follow https://github.com/signalfx/splunk-otel-collector-chart/blob/main/UPGRADING.md#0870-to-0880 to replace it with the upstream OpenTelemetry eBPF helm chart." }}
{{- end }}
{{- if not (eq (toString .Values.networkExplorer) "<nil>")}}
[WARNING] `networkExplorer` option is no longer supported. Please remove it from your custom values.yaml.
{{- end }}

0 comments on commit ff16015

Please sign in to comment.