-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics index from annotations #1053
Metrics index from annotations #1053
Conversation
@sbylica-splunk why is a new k8sattributes processor being added for all components instead of enhancing the existing agent's? I don't believe these attrs are necessary for o11y cloud cases so limiting to platform w/ metrics configurations seems preferable as well. |
Please rebase and rerun make render |
b5610ea
to
de50f76
Compare
Done |
I added a new processor because we already have similar use case for logs (k8sattributes processor) and I wanted to make sure it works the same way.
|
Yes, though I think we'll also want to ensure that the new attributes aren't exported as o11y metric dimensions via the signalfx exporter. I'm not sure if there's a way to do that other than duplicating pipelines or using a connector w/ an additional transform processor. Maybe @dmitryax has suggestions since I think he's better versed on the use case than I am. |
@sbylica-splunk please make it conditional. At least if |
examples/add-kafkametrics-receiver/rendered_manifests/configmap-agent.yaml
Outdated
Show resolved
Hide resolved
examples/add-kafkametrics-receiver/rendered_manifests/configmap-agent.yaml
Outdated
Show resolved
Hide resolved
examples/add-kafkametrics-receiver/rendered_manifests/configmap-agent.yaml
Outdated
Show resolved
Hide resolved
examples/add-kafkametrics-receiver/rendered_manifests/configmap-agent.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Outdated
Show resolved
Hide resolved
e41809e
to
fa754f7
Compare
Ok, so is there anything else to do? I'll squash current commits after this pr is good to go :) |
@sbylica-splunk please fix trailing whitespace issues as seen in the failing pre-commit job |
ad33c26
to
c30e41d
Compare
5d798f5
to
089710d
Compare
Description:
Added support for annotations in metrics index
Testing:
Unit test
Documentation:
Added short explanation to advanced-configuration.md