Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional extra configs for agent and cluster receiver #1330

Closed
wants to merge 1 commit into from

Conversation

chenlujjj
Copy link

Description:

Now the chart has defined some configs in the templates/config folder, and allow users to override them in the config part of the values.yaml file. For most use cases, it works perfect.

However, in our company there are more than 100 k8s clusters and the collector configuration differs here and there across these clusters. At the beginning we maintain the specific configs in each cluster's collector values.yaml file, but it quickly becomes a heavy burden. We need templating functionality for these extra configs, but helm doesn't support templating for values at the moment. So we come up with an idea: allow the user provide self-defined configmap as the collector configuration, which will be appended to the running command of the collector container.

For example, the command is /otelcol --config=/conf/relay.yaml now. If there exists extra configs, it will be /otelcol --config=/conf/relay.yaml --config=/conf-extra/relay.yaml

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:

Documentation:

@chenlujjj chenlujjj requested review from a team as code owners June 26, 2024 11:36
@jinja2
Copy link
Collaborator

jinja2 commented Jun 27, 2024

Hi @chenlujjj. Thank you for opening this PR. It would be best to file a Splunk idea to add this feature to our helm chart. Thanks!

@chenlujjj
Copy link
Author

Hi @jinja2 ,I've file a idea here: https://ideas.splunk.com/ideas/EID-I-2345

@atoulme atoulme closed this Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants