Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.58.0 #518

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Release v0.58.0 #518

merged 4 commits into from
Aug 29, 2022

Conversation

foram-splunk
Copy link
Contributor

No description provided.

@foram-splunk foram-splunk requested review from a team as code owners August 24, 2022 17:09
@dmitryax
Copy link
Contributor

The tests are failing. PTAL

@jvoravong
Copy link
Contributor

Test failures are related to #519

@jvoravong
Copy link
Contributor

Likely an upstream breaking change is causing this. DM'd Foram some possible leads.

@foram-splunk
Copy link
Contributor Author

For some reason, poll_interval and force_flush_period are changed from string to map. The following config is working.

filelog:
  poll_interval:
    duration: 200ms
  force_flush_period:
    duration: "0"

@jvoravong
Copy link
Contributor

@foram-splunk good work finding a fix. It looks like an upstream change likely caused this issues (I suspect open-telemetry/opentelemetry-collector#5839).

Before we merge this release, we should add a couple doc updates so users of this chart who have custom filelog receivers who use these configs have direction for how to address these issues when upgrading. Would you please add an entry to UPGRADING.md and include a an update for this breaking change in CHANGELOG.md (example)

@jvoravong jvoravong merged commit 38d05d5 into main Aug 29, 2022
@hvaghani221 hvaghani221 deleted the v0.58.0 branch August 30, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants