Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change networkExplorer.kernelCollector.useDockerMetadata default value to false. #665

Merged

Conversation

jmw51798
Copy link
Contributor

@jmw51798 jmw51798 commented Feb 9, 2023

No description provided.

@jmw51798 jmw51798 requested review from a team as code owners February 9, 2023 23:49
# assumes docker is being used for kubernetes containers
useDockerMetadata: true
# uncomment to enable enrichment using Docker metadata
# useDockerMetadata: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply changed the default value for NetworkExplorer useDockerMetadata. (It defaults to false here: https://github.com/jimwsplk/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/templates/network-explorer/kernel-collector-daemonset.yaml#L46)

Tested and validated deploying with this change in my dev environment.

@jvoravong jvoravong merged commit cfe5599 into signalfx:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants