Add persistent queues #675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt queue, nest persistentQueueEnabled in sendingQueue, add rendered examples
|
@omrozowicz-splunk can you please split the PR separately for each problem? |
jvoravong
reviewed
Mar 15, 2023
| @@ -0,0 +1,6 @@ | |||
| # Example of chart configuration | |||
There was a problem hiding this comment.
Nit: Can we rename this example to enabled-persistent-queue, I'm trying to keep our examples more organized?
jvoravong
reviewed
Mar 15, 2023
| # NOTE: The File Storage extension will persist state to the node's local file system. | ||
| # While using the persistent queue it is advised to increase memory limit for agent (agent.resources.limits.memory) | ||
| # to 1Gi. | ||
| persistentQueueEnabled: |
There was a problem hiding this comment.
We have sendingQueue.enabled right above this. Would matching the format above make sense here? I'm thinking something like this.
persistentQueue:
enabled: false
logs: true
metrics: true
storagePath: "/var/addon/splunk/persist"
jvoravong
reviewed
Mar 15, 2023
| # NOTE: The File Storage extension will persist state to the node's local file system. | ||
| # While using the persistent queue it is advised to increase memory limit for agent (agent.resources.limits.memory) | ||
| # to 1Gi. | ||
| persistentQueueEnabled: |
There was a problem hiding this comment.
We need to mention this feature is still alpha.
jvoravong
reviewed
Mar 15, 2023
| {{- end }} | ||
| {{- if (eq (include "splunk-otel-collector.persistentQueueEnabled" .) "true") }} | ||
| - name: patch-log-dirs | ||
| image: {{ template "splunk-otel-collector.image.initPatchLogDirs" . }} |
There was a problem hiding this comment.
- Where is this splunk-otel-collector.image.initPatchLogDir ?
- Do we need to use an init container for this? Does something prevent us from using the otel-collector container?
…file_storage extension only when metrics persistency is enabled
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things included in this PR:
Continuation of this PR: #668