-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove excessive istio attributes to avoid hitting the dimensions limit #765
Remove excessive istio attributes to avoid hitting the dimensions limit #765
Conversation
- istio_.* | ||
actions: | ||
- action: delete | ||
key: source_cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to add a new value and generate each action so it's more flexible as additional attributes are (un)wanted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean having another option in values.yaml for that?
I don't think we should add more configuration options to the already bloated values.yaml for this niche use case.
Overriding the set of attributes is already possible, just a bit more verbose, like:
agent:
config:
processors:
attributes/istio:
actions:
- action: delete
key: another_istio_attribute
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the current interface to enable istio metrics is pretty unflexible.
autodetect:
istio: true
We can probably rethink it to be able to add this list of attributes. Maybe as a follow-up effort. Let me know if you have any ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it would be great if we made this a bit more flexible. Maybe something like this?
autodetect:
istio:
enabled: true
# Explain why we remove these default set of attributes
excludeAttributes:
- attr1
- attr2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is the transition from bool value to the map in a backward-compatible way. We can try something out but I would rather do it as a follow-up effort not blocking the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed this #769
Add a new processor attributes/istio to drop excessive istio attributes and avoid running into the dimensions limit if scraping istio metrics is enabled.
5746e55
to
d609378
Compare
helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
Outdated
Show resolved
Hide resolved
….tpl Co-authored-by: Jina Jain <jina@signalfx.com>
Add a new processor attributes/istio to drop excessive istio attributes and avoid running into the dimensions limit if scraping istio metrics is enabled.
(OTL-2117)