Use "ContainerAdministrator" for windows node

[VihasMakwana]

For Linux nodes, the runAsUser is set to 0 by default if nothing is specified in values.yaml.
But for windows, it leaves this field empty.
It makes sense to set runAsUserName inside windowsOptions to ContainerAdministrator which is the root equivalent for Windows node

[rmfitzpatrick]

Are there specific issues this addresses and documented requirements for this user instead of ContainerUser or LocalSystem?

[VihasMakwana]

Ah, actually nope.
I came across #428.
It was mainly because of runAsUser being set even for Windows deployments. It was fixed AFAIK.
The reason why I raised this PR was to maintain consistency in Linux and Windows nodes.
In Linux, the agent's runAsUser is set to 0 i.e. root user if nothing is specified, but for Windows, it doesn't set anything so I made a few changes.

[VihasMakwana]

@dmitryax can you please re-review this one?

[jvoravong]

Should the proposed configuration be set when isWindows: true?
I'm surprised we didn't see these changes affect https://github.com/signalfx/splunk-otel-collector-chart/tree/main/examples/kubernetes-windows-nodes.

[VihasMakwana]

Yes @jvoravong , this will set only when isWindows is true

[jvoravong]

In that example isWindows: true. Your changes should have added content to the rendered files in the example after running a make render command, please look into this.

[VihasMakwana]

Okayy, will go through that

[VihasMakwana]

Okay @jvoravong, I see why this is happening.
securityContext is set if we've specified $securityContext in values.yaml or if we have logsEngine to otel and logsEnabled.
In rendered examples for windows, none of them are set, so it doesn't affect https://github.com/signalfx/splunk-otel-collector-chart/tree/main/examples/kubernetes-windows-nodes.