Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse k8s attributes processor configuration between agent and gateway #820

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

dmitryax
Copy link
Contributor

This also fixes an inconsistency between resource attributes added by default depending on whether the gateway is enabled or not. The gateway was missing the following attributes:

  • container.id
  • container.image.name
  • container.image.tag

@dmitryax dmitryax requested review from a team as code owners June 22, 2023 16:48
@dmitryax dmitryax force-pushed the reuse-k8s-attributes-processor branch from de5c842 to c5a022c Compare June 22, 2023 16:56
This also fixes an inconsistency between resource attributes added by default depending on whether the gateway is enabled or not. The gateway was missing the following attributes:
  - container.id
  - container.image.name
  - container.image.tag
@dmitryax dmitryax force-pushed the reuse-k8s-attributes-processor branch from c5a022c to 42e1da6 Compare June 22, 2023 16:57
@dmitryax dmitryax merged commit 3540756 into signalfx:main Jun 22, 2023
@dmitryax dmitryax deleted the reuse-k8s-attributes-processor branch June 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants