Skip to content

Commit

Permalink
Temporarily add a no-op flag metrics-addr
Browse files Browse the repository at this point in the history
This attribute is temporarily required to be set to make Splunk OTel Collector Helm chart to work on GKE/Autopilot.
  • Loading branch information
dmitryax authored and atoulme committed Dec 15, 2022
1 parent fe9e79c commit 220e320
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/settings/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,11 @@ func parseArgs(args []string) (*Settings, error) {
"Do not translate old configurations to the new format automatically. "+
"By default, old configurations are translated to the new format for backward compatibility.")

// Deprecated "--metrics-addr" flag is a noop, but temporarily required to run the collector GKE/Autopilot.
addressFlag := ""
flagSet.StringVar(&addressFlag, "metrics-addr", "", "")
flagSet.MarkHidden("metrics-addr")

// Experimental flags
flagSet.VarPF(settings.configDir, "config-dir", "", "").Hidden = true
flagSet.BoolVar(&settings.configD, "configd", false, "")
Expand Down

0 comments on commit 220e320

Please sign in to comment.