ensure --dry-run doesn't report expanded config values #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
commented
Jan 3, 2023
| @@ -126,13 +145,26 @@ func TestConfigSourceConfigMapProvider(t *testing.T) { | |||
| } else { | |||
| assert.ErrorContains(t, err, tt.wantErr) | |||
| assert.Nil(t, r) | |||
| return | |||
| break | |||
There was a problem hiding this comment.
I think this was an existing bug in the test that missed shutdown coverage
hughesjj
approved these changes
Jan 3, 2023
rmfitzpatrick
force-pushed
the
unexpandeddryrun
branch
from
d801862 to
39a9c72
Compare
atoulme
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
--dry-runwill provide the final config values with all config source and environment variables having been resolved/expanded. This is not desirable for dynamic* content. These changes add a newconfigprovider.Hookmechanism to provide additional components access of pre-resolving config content like* the config server currently does. The config server converter is updated to conform to the new interface.These also pick up existing missing imports and add an integration test with an additional testutil container helper.