Initial Discovery properties provider and config incorporation #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
discoveryproperties
branch
3 times, most recently
from
9b79500
to
379cf90
Compare
hughesjj
approved these changes
Jan 20, 2023
atoulme
reviewed
Jan 20, 2023
atoulme
approved these changes
Jan 20, 2023
rmfitzpatrick
force-pushed
the
discoveryproperties
branch
from
379cf90
to
7bbbdff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce a new
--set splunk.discovery.<property_content>mechanism and associatedSPLUNK_DISCOVERY_<property_content>env var for altering the discovery config content for a given--discoveryrun.Currently only receiver creator* sub-config fields and extension config value changes are supported but discovery rules and resource attributes should be added in a subsequent PR.
Also updating integration tests to exercise the functionality and fixing an unrelated bug in determining discovery component status.