Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url encode monitor IDs in SA receiver #266

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

Receiver creator instantiated names have quotes in them, which breaks collectd instance templating:
<Instance "[monitorID=receiver_creatorsmartagentnginx{endpoint="172.17.0.2:8080"}]">

These changes url encode the monitor name for monitor id usage instead of simply removing forward slashes.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #266 (d03b62a) into main (d6b531d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files          20       20           
  Lines        1490     1490           
=======================================
  Hits         1295     1295           
  Misses        160      160           
  Partials       35       35           
Impacted Files Coverage Δ
internal/receiver/smartagentreceiver/receiver.go 91.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b531d...d03b62a. Read the comment docs.

@rmfitzpatrick rmfitzpatrick merged commit 528ceb8 into main Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the sa_url_escape_monitor_name branch April 13, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants