Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/client-go from 0.27.4 to 0.28.0 in /internal/signalfx-agent #3521

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2023

Bumps k8s.io/client-go from 0.27.4 to 0.28.0.

Commits
  • 9081272 Update dependencies to v0.28.0 tag
  • fe76ecc Merge remote-tracking branch 'origin/master' into release-1.28
  • a715d8b Merge pull request #119876 from marosset/revert-118895
  • 3163e5a Revert "Merge pull request #118895 from RyanAoh/kep-1860"
  • 8d766e7 Avoid returning nil responseKind in v1beta1 aggregated discovery
  • dcfe307 Merge remote-tracking branch 'origin/master' into release-1.28
  • 7d2c3df .*: bump golang.org/x/net to v0.13.0
  • c5b1c13 Merge pull request #118644 from alexzielenski/apiserver/policy/namespaceParamRef
  • a98e74a Merge pull request #116469 from RomanBednar/pv-phase-transition-time
  • dcfedbe make update
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.27.4 to 0.28.0.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.27.4...v0.28.0)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested review from a team as code owners August 21, 2023 00:31
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 21, 2023
@jeffreyc-splunk
Copy link
Contributor

# github.com/signalfx/signalfx-agent/pkg/monitors/kubernetes/leadership
Error: internal\signalfx-agent\pkg\monitors\kubernetes\leadership\leadership.go:85:16: undefined: resourcelock.ConfigMapsLeasesResourceLock

@jinja2
Copy link
Contributor

jinja2 commented Aug 21, 2023

k8s.io/client-go v0.28.0 drops support for using ConfigMapLeases for leader-elections (upstream PR). We are switching smartagent receivers which support leader-election to use only Leases as opposed to the current behavior of using ConfigMaps and Leases. Smartagent receivers which might be using leader-election are kubernetes-events and kubernetes-cluster, but only if the config alwaysClusterReporter is set to false.

@jinja2 jinja2 requested a review from a team as a code owner August 22, 2023 23:16
@jinja2 jinja2 merged commit 41ec12f into main Aug 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the dependabot/go_modules/internal/signalfx-agent/k8s.io/client-go-0.28.0 branch August 23, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants