Add tests for express instrumentation #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyc-splunk
commented
Sep 1, 2023
Comment on lines
+303
to
+314
| # minimum supported node version required for profiling | ||
| node_version = "v16" | ||
|
|
||
| if distro in ("centos-7", "oraclelinux-7"): | ||
| # g++ for these distros is too old to install splunk-otel-js with node v16: | ||
| # g++: error: unrecognized command line option '-std=gnu++14' | ||
| # use the minimum supported node version without profiling instead | ||
| node_version = "v14" | ||
| elif distro in ("debian-stretch", "ubuntu-xenial"): | ||
| # these distros only provide python 3.5, but node v16 requires python 3.6+ | ||
| # use the minimum supported node version without profiling instead | ||
| node_version = "v14" |
There was a problem hiding this comment.
Limitations for older distros.
jeffreyc-splunk
force-pushed
the
zc-node-test
branch
from
3bfb535 to
148f71a
Compare
jeffreyc-splunk
force-pushed
the
zc-node-test
branch
from
148f71a to
682619c
Compare
jeffreyc-splunk
force-pushed
the
zero-config-dev
branch
from
610bd60 to
097f11e
Compare
jeffreyc-splunk
force-pushed
the
zc-node-test
branch
from
682619c to
849e350
Compare
atoulme
approved these changes
Sep 1, 2023
|
LGTM. I want to work on this in the long term dev branch, so I might merge this now if that's ok. |
jeffreyc-splunk
force-pushed
the
zero-config-dev
branch
from
097f11e to
0197637
Compare
jeffreyc-splunk
force-pushed
the
zc-node-test
branch
from
849e350 to
ed15fea
Compare
Works for me. |
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 7, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 8, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 14, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 21, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 25, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Sep 26, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 3, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 3, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 9, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 11, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 16, 2023
jeffreyc-splunk
added a commit
that referenced
this pull request
Oct 18, 2023
atoulme
added a commit
that referenced
this pull request
Oct 18, 2023
* [DNM] Zero-config C code to inject environment variables for Java and Node.js (#3514) * Remove sending a metric as part of auto-instrumentation (#3482) * refactor the code to inject allowed env vars * latest after pair programming * latest after review and pairing * only inject env vars for java and nodejs programs. Apply env vars from different files for java and nodejs * remove docker interactive and tty flags * wip * use arch var to set the name of the file to copy * make tests pass on arm64 * try to support arm * build for the proper platform * fix package build * review with Jason, test for env vars overrides * Make ALLOWED_ENV_VARS a single string defined through the preprocessor * Update instrumentation/tests/java/Dockerfile Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com> * load preload file same way as java test * move file locations to macros * use n functions to handle strings when possible --------- Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com> * Add systemd sample file to splunk-otel-auto-instrumention (#3506) * Add systemd sample file to splunk-otel-auto-instrumention * Update manual instructions * Include default /etc/splunk/zeroconfig_java.conf in deb/rpm packages * Update tests for new libsplunk.so * Run auto instrumentation workflow for the zero-config-dev branch * Include splunk-otel-js in auto instrumentation deb/rpm (#3540) * Add systemd sample file to splunk-otel-auto-instrumention * Update tests for new libsplunk.so * Include splunk-otel-js in auto instrumentation deb/rpm * Include default /etc/splunk/zeroconfig_node.conf in deb/rpm packages * Add tests for express instrumentation (#3566) * Update installer script for systemd auto instrumentation (#3536) * Rename zeroconfig config files (#3682) * Update ZC docs and tests for manual installation/configuration (#3700) * Update docs * Update splunk-otel-js to v2.4.2 * Combine sample systemd config files * Install splunk-otel-js globally for tests * Update deps installation for node tests * Update splunk-otel-js to v2.4.4 * Update linux-manual.md * Update test for centos/oraclelinux 7 arm64 --------- Co-authored-by: Anna U <104845867+aurbiztondo-splunk@users.noreply.github.com> * Update otlp endpoint for linux installer script (#3761) * Update otlp endpoint for linux installer script * remove 0.0.0.0 * Add debian bookworm for instrumentation tests * Update CHANGELOG.md --------- Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: Anna U <104845867+aurbiztondo-splunk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splunk-otel-auto-instrumentationpackage for both amd64 and arm64:splunk-otel-js:splunk-otel-jswith npm