Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chef tests #3628

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix chef tests #3628

merged 1 commit into from
Sep 12, 2023

Conversation

jeffreyc-splunk
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk commented Sep 11, 2023 •
edited
Loading

Convert chef tests from serverspec to inspec.

Follow-up to #3606 (comment).

@jeffreyc-splunk jeffreyc-splunk marked this pull request as ready for review September 11, 2023 18:42
@jeffreyc-splunk jeffreyc-splunk requested review from a team as code owners September 11, 2023 18:42
@rmfitzpatrick
Copy link
Contributor

Do you know what's declaring busser-serverspec as a dependency?

@jeffreyc-splunk
Copy link
Contributor Author

Do you know what's declaring busser-serverspec as a dependency?

It is a dependency of serverspec, which we were using as the verifier in test-kitchen: https://kitchen.ci/docs/verifiers/serverspec/

@rmfitzpatrick
Copy link
Contributor

rmfitzpatrick commented Sep 12, 2023 •
edited
Loading

It is a dependency of serverspec

I wasn't able to find an explicit declaration but wonder if test-kitchen or busser is dynamically installing it based on the verifier name in the suite path. Mainly curious and not tied to this PR content.*

@jeffreyc-splunk
Copy link
Contributor Author

It is a dependency of serverspec

I wasn't able to find an explicit declaration but wonder if test-kitchen or busser is dynamically installing it based on the verifier name in the suite path. Mainly curious and not tied to this PR content.*

I couldn't either... I think kitchen just installs it by default for serverspec: https://github.com/signalfx/splunk-otel-collector/actions/runs/6125267267/job/16626924536?pr=3606#step:4:325

@jeffreyc-splunk jeffreyc-splunk merged commit c709125 into main Sep 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-chef-tests branch September 12, 2023 15:54
weliasz pushed a commit to weliasz/splunk-otel-collector that referenced this pull request Sep 14, 2023
@jeffreyc-splunk @weliasz
Fix chef tests (signalfx#3628)
75bfae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyc-splunk @rmfitzpatrick