Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a file config source #397

Merged
merged 3 commits into from
May 18, 2021
Merged

Add a file config source #397

merged 3 commits into from
May 18, 2021

Conversation

pjanotti
Copy link
Contributor

Add a config source that supports the injection of files for feature parity with SA. A separate config source will be used to inject YAML templates.

@pjanotti
Copy link
Contributor Author

test failures: os.Chtimes used in Windows to "force file update" (i.e. 'touch') don't work in Linux. Looking for a proper multiplatform way.

@pjanotti pjanotti requested review from a team as code owners May 18, 2021 01:34
@tigrannajaryan
Copy link
Contributor

Can this and template source be the same and one config implementation? Do we need both?

@pjanotti
Copy link
Contributor Author

Per conversation let's unify the config sources after this PR and #402 are merged.

@rmfitzpatrick rmfitzpatrick merged commit 0d54124 into signalfx:main May 18, 2021
@pjanotti pjanotti deleted the add-fileconfigsource branch May 18, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjanotti @tigrannajaryan @rmfitzpatrick