Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove collectd/vmem #3993

Merged
merged 1 commit into from
Jan 3, 2024
Merged

remove collectd/vmem #3993

merged 1 commit into from
Jan 3, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023 •
edited
Loading

This PR removes the deprecated collectd/vmem monitor in favor of the vmem monitor, it was initially deprecated 3 years 10 months ago.

The deprecation notice notes:

    **This monitor is deprecated in favor of the `vmem` monitor.  The metrics
    should be fully compatible with this monitor.** This monitor will be
    removed in a future agent release.

@atoulme atoulme requested review from a team as code owners December 1, 2023 04:59
rmfitzpatrick
rmfitzpatrick previously requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace w/ logged deprecation notice for at least a release

@atoulme atoulme force-pushed the remove_collectd_vmem branch from c10af98 to dee49eb Compare December 7, 2023 01:39
@rmfitzpatrick rmfitzpatrick dismissed their stale review December 18, 2023 15:21

notice added

@atoulme atoulme merged commit 22130f7 into main Jan 3, 2024
45 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_collectd_vmem branch January 3, 2024 01:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@rmfitzpatrick rmfitzpatrick rmfitzpatrick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @rmfitzpatrick @crobert-1