Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify file and include config sources #419

Merged

Conversation

pjanotti
Copy link
Contributor

Unify files and include config sources. The main change is that the parameters of the file config source are now specified as parameters of the config source itself, see README.md for details.

pjanotti added 6 commits May 19, 2021 16:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pjanotti pjanotti requested review from a team as code owners May 19, 2021 23:41
@pjanotti
Copy link
Contributor Author

Test failure due to git differences on Windows between my machine and CI: on my machine I preserve original line endings on CI uses \n\a... thinking on how to properly fix it.

Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with provided suggestions

@rmfitzpatrick rmfitzpatrick merged commit 6f945f6 into signalfx:main May 21, 2021
@pjanotti pjanotti deleted the unify-file-and-include-configsource branch May 21, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants