Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python to 3.11.7 #4233

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update Python to 3.11.7 #4233

merged 1 commit into from
Feb 1, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 1, 2024

No description provided.

@atoulme atoulme requested review from a team as code owners February 1, 2024 00:37
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as tests pass.

Do we have a full list of all places the Python version is defined, and what all needs to be updated? I'm seeing a lot of references in CI actions as well, not sure if they should be updated with this or not.

@atoulme
Copy link
Contributor Author

atoulme commented Feb 1, 2024

@crobert-1 I did some searching through the repository and looked at past PRs: #3727 it seems these are the only 2 spots to update, for Linux and Windows respectively.

Copy link
Contributor

@jinja2 jinja2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this is a patch version update, I assume this wouldn't impact any custom collectd plugins 🤞

@atoulme
Copy link
Contributor Author

atoulme commented Feb 1, 2024

Our tests check collectd plugins, for the most part. Any gap in testing, we should make sure we catch it with more tests. Let me know if you see any gaps under https://github.com/signalfx/splunk-otel-collector/tree/main/tests/receivers/smartagent and we can add more tests :)

@atoulme atoulme merged commit 6d4d9f3 into main Feb 1, 2024
135 checks passed
@delete-merged-branch delete-merged-branch bot deleted the update_python branch February 1, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants