Remove windows-2019 from test matrix #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Windows 2022 and 2019 are similar enough, at the level of the artifacts for this repo, that running on Windows 2019 tests doesn't provide much, if any, value and expose CI runs to known issues with golang on Windows 2019, the common
go: CreateFile C:\Users\RUNNER~1\AppData\Local\Temp\go-build1611004282\b2864\settings.test.exe: Access is denied.Notice that both OTel collector core and contrib also don't run tests on Windows 2019, both use
windows-latestonly.I'm opting to keep the GH action matrices so when a new Windows is released we can for a short of period of time run tests on both versions.
Link to Jira:
https://splunk.atlassian.net/browse/OTL-2618
Testing:
N/A
Documentation:
N/A