Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed high alert vulnerabity #4407

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fixed high alert vulnerabity #4407

merged 2 commits into from
Mar 8, 2024

Conversation

samiura
Copy link

@samiura samiura commented Mar 8, 2024 •
edited
Loading

Description: fixed high vulnerability issue 201

Link to Splunk idea:

Testing:

Documentation:

@samiura samiura requested review from a team as code owners March 8, 2024 21:18
@crobert-1
Copy link
Contributor

Looks like a breaking change may have been pulled in:

Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/container.go:67:36: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/container.go:78:34: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.[20](https://github.com/signalfx/splunk-otel-collector/actions/runs/8209146121/job/22454217994?pr=4407#step:6:21).1/container.go:207:62: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/container.go:[21](https://github.com/signalfx/splunk-otel-collector/actions/runs/8209146121/job/22454217994?pr=4407#step:6:22)0:27: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/container.go:213:34: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/docker_auth.go:17:72: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/docker_auth.go:[23](https://github.com/signalfx/splunk-otel-collector/actions/runs/8209146121/job/22454217994?pr=4407#step:6:24):26: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/docker_auth.go:30:25: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/docker_auth.go:53:47: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/docker_auth.go:59:27: undefined: types.AuthConfig
Error: ../../../go/pkg/mod/github.com/testcontainers/testcontainers-go@v0.20.1/docker_auth.go:59:[27](https://github.com/signalfx/splunk-otel-collector/actions/runs/8209146121/job/22454217994?pr=4407#step:6:28): too many errors

@samiura samiura force-pushed the removed-high-alert-201 branch from acf7aef to f059526 Compare March 8, 2024 21:51
@samiura
Copy link
Author

samiura commented Mar 8, 2024

@crobert-1 This is why!

@samiura samiura merged commit 1084922 into signalfx:main Mar 8, 2024
43 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samiura @crobert-1 @atoulme