[receiver/discovery] Emit entity events only for matching receivers #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
only-emit-matching-entity-events
branch
3 times, most recently
from
407ab82 to
e18245f
Compare
samiura
approved these changes
Apr 19, 2024
Only the entity tracker will be responsible for emitting entity events. So we want to avoid sending entity state events for any observed endpoints. We need to send events only for those that we have defined discovery rules.
dmitryax
force-pushed
the
only-emit-matching-entity-events
branch
from
e18245f to
22375b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the entity tracker will be responsible for emitting entity events. So we want to avoid sending entity state events for any observed endpoints. We need to send events only for those that we have defined discovery rules.