Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests failing on main #4740

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix integration tests failing on main #4740

merged 1 commit into from
Apr 29, 2024

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Apr 28, 2024

The tests are failing in main after upgrade of the core dependency to 0.99 where the rpc/grpc metrics are not exported in the default (normal) telemetry level anymore. This change remove those metrics from the list of expected metrics by the integration tests

@dmitryax dmitryax force-pushed the fix-integration-test branch from 3999f1d to f98ac7d Compare April 29, 2024 04:31
@dmitryax dmitryax changed the title [DRAFT] Check integration tests failures Fix integration tests failing on main Apr 29, 2024
@dmitryax dmitryax marked this pull request as ready for review April 29, 2024 04:32
@dmitryax dmitryax requested review from a team as code owners April 29, 2024 04:32
The tests are failing in main after upgrade of the core dependency to 0.99 where the rpc/grpc metrics are not exported in the default (normal) telemetry level anymore. This change remove those metrics from the list of expected metrics by the integration tests
@dmitryax dmitryax force-pushed the fix-integration-test branch from f98ac7d to 5a3b92e Compare April 29, 2024 14:34
@dmitryax dmitryax requested a review from a team as a code owner April 29, 2024 14:34
@dmitryax dmitryax merged commit 26ed000 into main Apr 29, 2024
27 checks passed
@dmitryax dmitryax deleted the fix-integration-test branch April 29, 2024 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants