Fix agent startup with security manager #1208
Conversation
|
|
||
| @Override | ||
| public String name() { | ||
| return delegate.name(); |
There was a problem hiding this comment.
There are now 2 LoggingCustomizers with the same name. Is it guaranteed that ours will always be the one that runs? Should we perhaps exclude the original one from the SPI file?
There was a problem hiding this comment.
Currently all our services are listed before upstream services in the service files.
Excluding it seems like fine idea, but actually doing it will probably require an unhealthy amount of gradle magic. I think we would need build a transformer as described in https://imperceptiblethoughts.com/shadow/configuration/merging/#merging-service-descriptor-files WDYT is there a simpler way to do this? Should I attempt the transformer approach?
|
@laurit Can you please provide a brief description in this PR that explains the core problem and how this change improves it? |
@breedx-splk comment updated |
open-telemetry/opentelemetry-java-instrumentation#7983 adds an experimental option to improve compatibility with security manager to upstream agent. This pr adds a test for running our agent with enabled security manger and moves calls to methods that require privileges, such as
System.setPropertyandSystem.getenv, to a later point where agent code has the required privileges.