Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable @typescript-eslint/member-ordering rule #883

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

Joozty
Copy link
Member

@Joozty Joozty commented Nov 6, 2024

Description

This PR introduces deterministic sorting for classes and interfaces to improve consistency in the structure of our codebase. By sorting members in a predefined order, we can reduce noise in diffs, especially when additional properties or members are added over time. This change ensures that new members will not disrupt the overall order, resulting in smaller diffs.

Type of change

Delete options that are not relevant.

  • Chore or internal change (changes not visible to the consumers of the package)

How has this been tested?

Just sorting. No need to create tests.

@Joozty Joozty marked this pull request as ready for review November 6, 2024 11:53
@Joozty Joozty requested review from a team as code owners November 6, 2024 11:53
@Joozty Joozty self-assigned this Nov 6, 2024
@Joozty Joozty requested review from potty and millcek November 6, 2024 11:57
Base automatically changed from chore/prettier to main November 6, 2024 12:14
@Joozty Joozty merged commit c3c3838 into main Nov 6, 2024
6 checks passed
@Joozty Joozty deleted the chore/sorting branch November 6, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants