feat: add option to save session data to local storage #900
+304
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Nov 29, 2024
Joozty
reviewed
Dec 4, 2024
| if ( | ||
| !sessionState.id || | ||
| typeof sessionState.id !== 'string' || | ||
| !sessionState.id.length || |
There was a problem hiding this comment.
Do you need this here... I guess it is covered with !== 32
There was a problem hiding this comment.
This was part of the original code, I'm refactoring this in upcoming PR.
Joozty
reviewed
Dec 4, 2024
| !sessionState.id || | ||
| typeof sessionState.id !== 'string' || | ||
| !sessionState.id.length || | ||
| sessionState.id.length !== 32 |
There was a problem hiding this comment.
could you please use SESSION_ID_LENGTH? I mean can be done in the upcoming PR
There was a problem hiding this comment.
Sure, it will be improved in upcoming PR.
Joozty
approved these changes
Dec 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
initconfig optionuseLocalStorageto save session data to local storage instead of cookie. It's mandatory for environments where cookie isn't usable, like Electron apps.List Github issue(s) which this PR fixes.
Type of change
Delete options that are not relevant.
How has this been tested?
Delete options that are not relevant.